Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Always First Functionality #173

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Added Always First Functionality #173

wants to merge 20 commits into from

Conversation

CaptCorpMURICA
Copy link

@CaptCorpMURICA CaptCorpMURICA commented Apr 26, 2023 •
edited
Loading

This pull request resolves #164.

  • This enables the new file type F__*.sql which is processed before all other file types.
  • This option defaults to False but can be enabled with the configuration -af or --always-first. This ensures that these files can be selectively executed depending on the environment.
    • e.g. In the CI/CD pipeline, you enable this configuration option when you need to clone the production environment to create the QA environment. However, this option is turned off for the elevation from QA to Prod because no cloning operation is taking place.
  • Tests were added to ensure the functionality works as designed. These tests cove:
    • Returning the proper number of files executed when the option is turned on or off.
    • Returning expected errors based on naming conventions.
    • Validating the appropriate data for the Change History Table.
  • Added this new functionality to the README documentation.

CaptCorpMURICA and others added 18 commits April 25, 2023 15:37
@CaptCorpMURICA
Added --always-first to the existing tests
693f42b
@CaptCorpMURICA
Added tests for Always First files
2e2591b 
Added tests to ensure always first files are executed properly including: executing multiple files, executing no files when option is False, expected error handling, and file execution order.
@CaptCorpMURICA
Added Always First functionality for Issue 164
7b1fc75 
Added the ability to execute specific files first in the execution order as well as an option to turn off processing of these files altogether. This functionality is best used when rebuilding the QA or STG clones during the CI/CD process.
@CaptCorpMURICA
Updated verbiage around config option
5b565df
@CaptCorpMURICA
Updated README for Issue 164
ca687f6 
Added documentation around Always First functionality from Issue 164
@CaptCorpMURICA
Added Order Test without AF
fc467fa
@CaptCorpMURICA
Merge pull request #1 from CaptCorpMURICA/Issue164
daa4dfd 
Issue164
@CaptCorpMURICA
Updated from AF to F
fe727e6
@CaptCorpMURICA
Updated to add bool for Always First
97c842b
@CaptCorpMURICA
Added bool for Always First
153297c
@CaptCorpMURICA
Changed from AF to F
6810784
@CaptCorpMURICA
Merge pull request #2 from CaptCorpMURICA/Issue164
ac74053 
Changed from AF to F
@CaptCorpMURICA
Corrected pandas import bug
42cb953 
Added Always First parameter to tests
@CaptCorpMURICA
Update cli.py
a039418
@CaptCorpMURICA
Reordered jinja processor to correct processing order error
c1a9a91
@CaptCorpMURICA
Merge remote-tracking branch 'origin/master'
621a2ea
@CaptCorpMURICA
Removed extra apply_change_script
ea2746c 
Duplicate apply_change_script was identified in the Always First processing block. It was not needed and removed.
@CaptCorpMURICA
Grammer Updates
4776826
@CaptCorpMURICA
Copy link
Author

Is there an update on when this will be reviewed?

@CaptCorpMURICA CaptCorpMURICA mentioned this pull request Oct 5, 2023
Open
@sfc-gh-tmathew sfc-gh-tmathew added enhancement New feature or request Development in Progress Will be addressed in upcoming release labels Nov 2, 2023
@sfc-gh-tmathew
Copy link
Collaborator

@CaptCorpMURICA Will discuss this next week and get back to you. Thank you for your contribution and your patience while we catchup on open items and PRs.

@sfc-gh-tmathew sfc-gh-tmathew self-assigned this Nov 2, 2023
@sfc-gh-tmathew sfc-gh-tmathew mentioned this pull request Nov 2, 2023
Open
@sfc-gh-tmathew sfc-gh-tmathew linked an issue Nov 2, 2023 that may be closed by this pull request
Option to change order of execution for scripts #115
Open
@jzking
Copy link

jzking commented Jan 17, 2024

Any discussion on when this might make it into a release? Thank you

@CaptCorpMURICA
Copy link
Author

Any discussion on when this might make it into a release? Thank you

I just welcomed my first child, so I haven't had the ability to implement the requested changes. I'll try to get it wrapped up in the next month or so.

@jzking
Copy link

jzking commented Jan 17, 2024 •
edited
Loading

Any discussion on when this might make it into a release? Thank you

I just welcomed my first child, so I haven't had the ability to implement the requested changes. I'll try to get it wrapped up in the next month or so.

Congratulations !! Let me know if I can help (with this PR, you are on your own with the baby LOL!)

@mw243270
Copy link

Any update on this one?

@rvanlinge-scripps
Copy link

It'd be great to add into the README file along with the other prefix file name section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jhansen sfc-gh-jhansen Awaiting requested review from sfc-gh-jhansen

@sfc-gh-twhite sfc-gh-twhite Awaiting requested review from sfc-gh-twhite

At least 1 approving review is required to merge this pull request.

Assignees

@sfc-gh-tmathew sfc-gh-tmathew

Labels
Development in Progress Will be addressed in upcoming release enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Always Execute First Functionality Option to change order of execution for scripts
5 participants
@CaptCorpMURICA @sfc-gh-tmathew @jzking @mw243270 @rvanlinge-scripps