Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review for 3.6.0 #195

Merged
merged 9 commits into from
Sep 6, 2023
Merged

Code review for 3.6.0 #195

merged 9 commits into from
Sep 6, 2023

Conversation

sfc-gh-jhansen
Copy link
Collaborator

See the CHANGELOG.md for the details.

sfc-gh-twhite
sfc-gh-twhite approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-twhite sfc-gh-twhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! I think upping the minor version will make sense for the session reset.

@sfc-gh-jhansen sfc-gh-jhansen merged commit d638a5c into master Sep 6, 2023
4 checks passed
This was referenced Sep 6, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-twhite sfc-gh-twhite sfc-gh-twhite approved these changes

@IndexSeek IndexSeek Awaiting requested review from IndexSeek

Assignees

@sfc-gh-jhansen sfc-gh-jhansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jhansen @sfc-gh-twhite @IndexSeek