Format with black #217
Merged
Format with black #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 10, 2024 11:29
wrap long strings prefer f-strings fix type annotations
sfc-gh-tmathew
added
enhancement
|
Thank you for opening this, @zanebclark! I apologize, we have been behind on many of these PRs and Issues and are trying to catch up. Many of these formatting changes had been on our roadmap and have been taken care of elsewhere since then. I do think that there are portions of this we would like to use, particularly exploring flake8 and some of the type annotation work; once we fold in some of the other upstream changes, I would like to include this one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the black formatter to the pre-commit hooks along with the flake8 linter. I addressed the issues raised by these tools along with some formatting and type hint errors. The functionality of the script should be the same. The development experience should be a bit nicer.