Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle all Task parameters in SDK #3103

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat: Handle all Task parameters in SDK #3103

merged 3 commits into from
Sep 30, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Changes

  • Picked which parameters should be used in tasks (internal doc).
  • Generated parameter asserts and used them in integration tests.
  • Minor change in assertion generating template (it was failing in my case because it was creating single letter variable which was t in this case and it conflicted with parameter t).

@github-actions GitHub Actions
Copy link

Integration tests failure for 324d025048c84550f48d458a8bf7c5744a59c5e0

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review September 24, 2024 12:31
@github-actions GitHub Actions
Copy link

Integration tests failure for d8583e6af3bc2f8995b0004f188358397fd933ad

@github-actions GitHub Actions
Copy link

Integration tests failure for 74ca1b9f24d40ad6dbedf0d6d30edb9e5d7b9c37

@github-actions GitHub Actions
Copy link

Integration tests failure for f486fc912e287705c1ba519339980cf4009f5592

@github-actions GitHub Actions
Copy link

Integration tests failure for ef185a7c6673bf72eafd8d1955887add79638c69

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 08ae072 into main Sep 30, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the tasks-sdk-parameters branch September 30, 2024 08:58
@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-jmichalak