Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account_parameter.go #3108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Richard-Barrett
Copy link

Fixes #1679

  • Added error handling to check if defaultValue is nil.
  • Added error statements to provide better insight into what’s happening when the account parameter is being reset.
  • More detailed error messages to give you more context when debugging.

Test Plan

  • acceptance tests

References

defaultValue := defaultParameter.Default
if defaultValue == "" {
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is incorrect. There are parameters which default to none value (e.g. https://docs.snowflake.com/en/sql-reference/parameters#query-tag).

@sfc-gh-jcieslak
Copy link
Collaborator

sfc-gh-jcieslak commented Oct 2, 2024

Hey @Richard-Barrett 👋
Thank You for your contribution. We can merge the change after you apply the change proposed by @sfc-gh-asawicki. Just a reminder for future contributions, please familiarize yourself with our contribution guideline. We highly recommend reaching out to the team (could be through GitHub issue or any other way) before creating such change as this one. This change provides value to the provider, but we will be refactoring this part soon and it will be entierely changed due to the fact that SET shouldn't be used in Delete operation (it should be UNSET which is not yet supported by our SDK). Anyway, please consult with us the change next time and again Thank You for helping us :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Compilation Error While Deleting a snowflake_account_parameter Resource.
3 participants