Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump golang-ci lint to 1.61 #3112

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore: Bump golang-ci lint to 1.61 #3112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export TERRAFORM_PLUGIN_LOCAL_INSTALL=$(TERRAFORM_PLUGINS_DIR)/$(BASE_BINARY_NAM
default: help

dev-setup: ## setup development dependencies
@which ./bin/golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin v1.55.2
@which ./bin/golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin v1.61.0
cd tools && mkdir -p bin/
cd tools && env GOBIN=$$PWD/bin go install github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs
cd tools && env GOBIN=$$PWD/bin go install mvdan.cc/gofumpt
Expand Down
1 change: 0 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ func main() {
muxServer.ProviderServer,
serveOpts...,
)

if err != nil {
log.Fatal(err)
}
Expand Down
9 changes: 4 additions & 5 deletions pkg/sdk/views_gen_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package sdk

import (
"fmt"
"testing"
)

Expand Down Expand Up @@ -530,7 +529,7 @@ func TestViews_Show(t *testing.T) {
Database: id,
},
}
assertOptsValidAndSQLEquals(t, opts, fmt.Sprintf("SHOW VIEWS IN DATABASE %s", id.FullyQualifiedName()))
assertOptsValidAndSQLEquals(t, opts, "SHOW VIEWS IN DATABASE %s", id.FullyQualifiedName())
})

t.Run("in schema", func(t *testing.T) {
Expand All @@ -541,7 +540,7 @@ func TestViews_Show(t *testing.T) {
Schema: id,
},
}
assertOptsValidAndSQLEquals(t, opts, fmt.Sprintf("SHOW VIEWS IN SCHEMA %s", id.FullyQualifiedName()))
assertOptsValidAndSQLEquals(t, opts, "SHOW VIEWS IN SCHEMA %s", id.FullyQualifiedName())
})

t.Run("in application", func(t *testing.T) {
Expand All @@ -550,7 +549,7 @@ func TestViews_Show(t *testing.T) {
opts.In = &ExtendedIn{
Application: id,
}
assertOptsValidAndSQLEquals(t, opts, fmt.Sprintf("SHOW VIEWS IN APPLICATION %s", id.FullyQualifiedName()))
assertOptsValidAndSQLEquals(t, opts, "SHOW VIEWS IN APPLICATION %s", id.FullyQualifiedName())
})

t.Run("in application package", func(t *testing.T) {
Expand All @@ -559,7 +558,7 @@ func TestViews_Show(t *testing.T) {
opts.In = &ExtendedIn{
ApplicationPackage: id,
}
assertOptsValidAndSQLEquals(t, opts, fmt.Sprintf("SHOW VIEWS IN APPLICATION PACKAGE %s", id.FullyQualifiedName()))
assertOptsValidAndSQLEquals(t, opts, "SHOW VIEWS IN APPLICATION PACKAGE %s", id.FullyQualifiedName())
})

t.Run("all options", func(t *testing.T) {
Expand Down
Loading