refactor: improve pdf-tools selection (PR syl20bnr#15740) (syl20bnr#1…

…5762)

layers/+readers/pdf/packages.el

@@ -31,12 +31,6 @@
     :mode (("\\.pdf\\'" . pdf-view-mode))
     :init
     (spacemacs//pdf-tools-setup-transient-state)
-
-    (add-hook 'pdf-view-mode-hook
-              (lambda () (add-hook 'evil-evilified-state-entry-hook
-                                   (lambda () (remove-hook 'activate-mark-hook 'evil-visual-activate-hook t))
-                                   nil t)))
-
     :config
     (progn
       (pdf-tools-install)
@@ -69,6 +63,12 @@
         "O" 'pdf-outline
         "n" 'pdf-view-midnight-minor-mode)
 
+      (evil-define-key 'visual pdf-view-mode-map
+        "y" 'pdf-view-kill-ring-save
+        (kbd "<C-down-mouse-1>") 'pdf-view-mouse-extend-region
+        (kbd "<M-down-mouse-1>") 'pdf-view-mouse-set-region-rectangle
+        (kbd "<down-mouse-1>")  'pdf-view-mouse-set-region)
+
       ;; TODO: Make `/', `?' and `n' work like in Evil
       (evilified-state-evilify-map pdf-view-mode-map
         :mode  pdf-view-mode
@@ -102,8 +102,8 @@
         "r"   'pdf-view-revert-buffer
         "o"   'pdf-links-action-perform
         "O"   'pdf-outline
-        "zr"  'pdf-view-scale-reset
-        "y"   'pdf-view-kill-ring-save)
+        "zr"  'pdf-view-scale-reset)
+
       (evilified-state-evilify-map pdf-outline-buffer-mode-map
         :mode  pdf-outline-buffer-mode
         :eval-after-load pdf-outline