Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qidi profile bugs #5801

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Fix Qidi profile bugs #5801

merged 7 commits into from
Jun 24, 2024

Conversation

HYzd766
Copy link
Contributor

@HYzd766 HYzd766 commented Jun 22, 2024

Solve a litte bug and make some changes

@Ocraftyone
Copy link
Contributor

Can your provide move of a description on the fixed bug?

@HYzd766
Copy link
Contributor Author

HYzd766 commented Jun 24, 2024

There is a code in the fdm_qidi_x3_common.json file called "thumnails_format": "ColPic", which is not compatible with this version. After deleting it, I fixed the bug and found that it is not compatible with this version

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever
Copy link
Owner

There is a code in the fdm_qidi_x3_common.json file called "thumnails_format": "ColPic", which is not compatible with this version. After deleting it, I fixed the bug and found that it is not compatible with this version

hehehe, there was a typo there before. it should be thumbnails_format.
Anyway, with the new thumbnail revamp, this parameter is not required anymore.

@SoftFever SoftFever merged commit 63dcf82 into SoftFever:main Jun 24, 2024
1 check passed
@SoftFever SoftFever changed the title Bug Repaired Fix Qidi profile bugs Jun 25, 2024
@M-B-work
Copy link

Let me start by saying that I have an Xplus3 and always used 2.0 and switched directly to 2.1.1
The miniatures thing never worked. I found this post and would like clarification or help if possible, I tried to add _format to thumbmail, I tried to replace png and alternate hits, also varying many formats, but nothing, nothing works. Have you solved this thing? Could I try it too thanks to your suggestions? Thank you

@HYzd766
Copy link
Contributor Author

HYzd766 commented Jul 16, 2024

I have submitted the modifications regarding the issue you mentioned

@M-B-work
Copy link

Ho inviato le modifiche relative al problema da te menzionato

So there is no solution at the right time? We are a few users in a qidi group who have encountered this, we will have to wait for a new version right? Anyway we momentarily continue to use the 2.0, we trust the orca team for a solution, thank you

@HYzd766
Copy link
Contributor Author

HYzd766 commented Jul 16, 2024

Ho inviato le modifiche relative al problema da te menzionato

所以在正确的时间没有解决方案吗?我们是奇地群中的几个用户遇到过这种情况,我们将不得不等待新版本吧?无论如何,我们暂时继续使用 2.0,我们相信 orca 团队的解决方案,谢谢

image

Thank you for your support. You can modify this to an illustration so that the thumbnail can be displayed, which can be used first. Alternatively, after the modifications we submitted are approved, the next version can be restored to normal use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants