Review 1

SonarSource · Mar 24, 2023 · 08ef95f · 08ef95f
1 parent 7e2de77
commit 08ef95f
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/...sts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs b/...sts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
@@ -648,7 +648,7 @@ void OutParams(int? iParam)
         _ = iLocal.Value;                                // Compliant
 
         iLocal = null;
-        ModifyOutParamAndRead(out iLocal, iLocal.Value); // Compliant, FN
+        ModifyOutParamAndRead(out iLocal, iLocal.Value); // FN
 
         iLocal = null;
         ReadAndModifyOutParam(iLocal.Value, out iLocal); // Noncompliant
@@ -672,7 +672,19 @@ void RefParams(int? iParam)
         ModifyRefParam(ref iLocal);
         _ = iLocal.Value;                                // Compliant
 
+        iLocal = null;
+        ModifyRefParamAndRead(ref iLocal, iLocal.Value); // FN
+
+        iLocal = null;
+        ReadAndModifyRefParam(iLocal.Value, ref iLocal); // Noncompliant
+
+        nullableField = null;
+        ModifyRefParam(ref nullableField);
+        _ = nullableField.Value;                         // Compliant
+
         static void ModifyRefParam(ref int? i) => i = null;
+        static void ModifyRefParamAndRead(ref int? i1, int? i2) => i1 = i2;
+        static void ReadAndModifyRefParam(int? i1, ref int? i2) => i2 = i1;
     }
 }