Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AD0001 in S138: NullReferenceException #7155

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix AD0001 in S138: NullReferenceException #7155

merged 1 commit into from
May 2, 2023

Conversation

antonioaversa
Copy link
Contributor

Fixes #7134

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@antonioaversa antonioaversa changed the title S103: Fix exception when extern local functions are defined S138: Fix exception when extern local functions are defined May 2, 2023
@antonioaversa antonioaversa changed the title S138: Fix exception when extern local functions are defined Fix AD0001 in S138: NullReferenceException May 2, 2023
@antonioaversa antonioaversa marked this pull request as ready for review May 2, 2023 07:35
Tim-Pohlmann
Tim-Pohlmann reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cristian-ambrosini-sonarsource
cristian-ambrosini-sonarsource approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the Antonio/S103-repro branch May 2, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann left review comments

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix AD0001 in S138: NullReferenceException
3 participants
@antonioaversa @Tim-Pohlmann @cristian-ambrosini-sonarsource