Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix drag area of non-empty sortable init #1893

Closed
wants to merge 1 commit into from
Closed

fix drag area of non-empty sortable init #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ mock.png
.build*
jquery.fn.*
.idea/
.vscode
4 changes: 4 additions & 0 deletions Sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2109,6 +2109,10 @@

let elLastChild = lastChild(el, options.draggable);

if (rootEl !== el) {
elLastChild = null;
}

if (
!elLastChild ||
(_ghostIsLast(evt, vertical, this) && !elLastChild.animated)
Expand Down
4 changes: 4 additions & 0 deletions modular/sortable.complete.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2103,6 +2103,10 @@ Sortable.prototype = /** @lends Sortable.prototype */ {

let elLastChild = lastChild(el, options.draggable);

if (rootEl !== el) {
elLastChild = null;
}

if (
!elLastChild ||
(_ghostIsLast(evt, vertical, this) && !elLastChild.animated)
Expand Down
4 changes: 4 additions & 0 deletions modular/sortable.core.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2103,6 +2103,10 @@ Sortable.prototype = /** @lends Sortable.prototype */ {

let elLastChild = lastChild(el, options.draggable);

if (rootEl !== el) {
elLastChild = null;
}

if (
!elLastChild ||
(_ghostIsLast(evt, vertical, this) && !elLastChild.animated)
Expand Down
4 changes: 4 additions & 0 deletions modular/sortable.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2103,6 +2103,10 @@ Sortable.prototype = /** @lends Sortable.prototype */ {

let elLastChild = lastChild(el, options.draggable);

if (rootEl !== el) {
elLastChild = null;
}

if (
!elLastChild ||
(_ghostIsLast(evt, vertical, this) && !elLastChild.animated)
Expand Down
4 changes: 4 additions & 0 deletions src/Sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,6 +1268,10 @@ Sortable.prototype = /** @lends Sortable.prototype */ {

let elLastChild = lastChild(el, options.draggable);

if (rootEl !== el) {
elLastChild = null
}

if (
!elLastChild ||
(_ghostIsLast(evt, vertical, this) && !elLastChild.animated)
Expand Down