add onSendEvent and examples with new Spacebrew UI #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: example_drawing_tool example_shared_canvas tweaks to main ofxSpacebrew src
| @@ -398,6 +398,7 @@ namespace Spacebrew { | |||
| if ( bConnected ){ | |||
| #ifdef SPACEBREW_USE_OFX_LWS | |||
| client.send( m.getJSON( config.clientName ) ); | |||
| ofNotifyEvent(onSendEvent, m.name, this); | |||
There was a problem hiding this comment.
I think this is the only thing I would change!
- It should be outside of the SPACEBREW_USE_OFX_LWS preprocessor block
- I think it should pass the Message. Technically, apps can have > 1 publisher with the same name as long as they are different types!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
example_drawing_tool
example_shared_canvas
tweaks to main ofxSpacebrew src