-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit use of advance monitors for loading #1201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test show that for small content the Advanced Monitors are actually worse.
Limited testing showed
for very small data (under 100 bytes) Advance Monitors where very poor
for very large data (over 100,000 bytes advance monitors where much faster)
12800 bytes 50 packets appears a reasonable toggle point
There is a cfg disable_advanced_monitor_usage_for_data_in
But that is an all or nothing approach
This PR automatically switches between the 2 strategies.
If No ds regiond's content is larger than the cutoff
EDIT: Fixed routes are still created, loaded and reported. But the report now has a cfg flag False by default
Python
Java
If one or more content is larger
Python
Router timeouts are created
For each content the choice is made which to use
Java
For each content the choice is made which to use
See:
Must be done at the same time as:
SpiNNakerManchester/sPyNNaker#1472
Tested by:
SpiNNakerManchester/sPyNNaker#1472
SpiNNakerManchester/IntegrationTests#281