Provenance straight to and from the database. #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we had one type of provenance which was collected in a lists and later written to xml, json or sqllite.
In this pr provenance is written to the sql database as soon as possible.
Instead of a single type do all provenance table there are now several different tables
Due to the significant change in the provenance structure there was no easy way to convert the xml and json writers so they have been removed.
As far as possible all the information previous stored as provenance has been retained.
Messages attached to provenance items have been retained even when possibly too long with an execption of one class where they where no longer correct.
Algorithms that read in provenance lists now obtain the data from the sql
This is a separate set of changes to the no_exector ones so can be reviewed and merged before or after those.
Must be done at the same time as:
SpiNNakerManchester/sPyNNaker#1119
SpiNNakerManchester/SpiNNakerGraphFrontEnd#201
tested by:
SpiNNakerManchester/IntegrationTests#80
|Fixes: #867