Merge pull request #1430 from SpiNNakerManchester/pylint_strict

make Pylint checks much stricter

.github/workflows/python_actions.yml

@@ -89,6 +89,7 @@ jobs:
       uses: ./support/actions/pylint
       with:
         package: ${{ env.BASE_PKG }}
+        exitcheck: 31 # Action fails on any message
         language: en_GB
     - name: Lint with mypy
       run: mypy ${{ env.BASE_PKG }}

.pylint_dict.txt

@@ -24,124 +24,128 @@ Petrut
 Vogels
 
 # Our abbreviations/names
-MPI
 gsyn
-spinnman
+MPI
+Omnibot
 pacman
+pushbot
 spalloc
+spinnman
 Omnibot
-pushbot
 
 # Our "special" words
-multapse
-spiketrain
-spiketrains
+analog
+componentised
+config
 heatmap
-multiplicator
 generatable
-componentised
-rng
+multapse
+multiplicator
+or'ed
 PLoS
+pn
 rewirings
-analog
+rng
+spiketrain
+spiketrains
 stdev
-or'ed
-pn
-config
 
 # Our Python types
-ApplicationGraph
-AbstractVertex
-ApplicationVertex
-MachineVertex
+AbstractCurrentSource
+AbstractMulticastControllableDevice
 AbstractPopulationVertex
+AbstractSDRAM
+AbstractSynapseType
+AbstractVertex
 ApplicationEdge
+ApplicationEdgePartition
+ApplicationGraph
+ApplicationVertex
+CommonRegions
+ConnectionHolder
+ConstantSDRAM
+CoreSubset
+CoreSubsets
+DataSpecificationGenerator
 DataType
-MachineEdge
-ProjectionApplicationEdge
 DelayedApplicationEdge
 DelayExtensionVertex
-ApplicationEdgePartition
-SourceSegmentedSDRAMMachinePartition
-SynapseRegionReferences
+EIEIOPrefix
+EIEIOType
+ExecutableTargets
+FPGAConnection
+GeneratorData
+IDMixin
+MachineEdge
+MachineVertex
+MDSlice
+ModuleType
+MultiRegionSDRAM
+NeuronRegions
+ProjectionApplicationEdge
+PopulationApplicationVertex
 PopulationBase
 PopulationView
-IDMixin
-RandomDistribution
-ConnectionHolder
-FPGAConnection
 ProgressBar
-AbstractSynapseType
+RandomDistribution
+SourceSegmentedSDRAMMachinePartition
+SpinnmanIOException
 SynapseInformation
+SynapseRegionReferences
 SynapseRegions
-ExecutableTargets
-AbstractSDRAM
-ConstantSDRAM
 VariableSDRAM
-MultiRegionSDRAM
-AbstractMulticastControllableDevice
-CommonRegions
-NeuronRegions
-DataSpecificationGenerator
-CoreSubset
-CoreSubsets
-SpinnmanIOException
-AbstractCurrentSource
-GeneratorData
-EIEIOType
-EIEIOPrefix
-RandomDistribtuion
 
-# Others' Python types
-NumpyRNG
-NativeRNG
-TemplateEngine
-BaseStructure
+# Others' Python types (including PYNN terms)
+AnalogSignal
 BaseIO
-FileIO
+BaseStructure
+ChannelIndex
 CSet
+ctype
+dtype
+FileIO
+GSLRNG
+NumpyRNG
+NativeRNG
 NeuronCurrentSource
-AnalogSignal
+RandomDistribtuion
+RandomState
 SpikeTrain
+TemplateEngine
 StandardTextFile
-dtype
 UnitTime
-RandomState
-ChannelIndex
-ctype
-GSLRNG
 
 # Python packages
+baseio
+connset
+ctypes
 csa
+cset
 datetime
+graphviz
 neo
 pynn
 pyNN
-standardmodels
-graphviz
 rawio
-baseio
+standardmodels
 struct
-cset
-connset
 unitquantity
-ctypes
 
 # Misc (arguments, etc.)
-Wi
-sdram
-csv
+addr
 cellclass
 cellparams
-structs
-rd
-tstop
-params
+csv
 csvfile
 db
 dt
-vals
-addr
-simtime
 eieio
+params
+rd
+sdram
+simtime
+structs
+tstop
+vals
+Wi
 ylabel

spynnaker/pyNN/models/common/local_only_2d_common.py

@@ -56,7 +56,7 @@ def get_div_const(value):
 
 def get_delay_for_source(incoming):
     """ Get the vertex which will send data from a given source projection,
-        along with the delay stage and locally-handled delay valule
+        along with the delay stage and locally-handled delay value
 
     :param Projection incoming: The incoming projection to get the delay from
     :return: The vertex, the local delay, the delay stage