Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 back for spynnaker_integration_tests, spynnaker8 directories #1063

Merged
merged 7 commits into from
May 6, 2021

Conversation

andrewgait
Copy link
Contributor

@andrewgait andrewgait commented Apr 22, 2021

flake8 was no longer running on spynnaker_integration_tests or spynnaker8 - also tidied up based on local run of flake8

Tested by SpiNNakerManchester/IntegrationTests#45

@andrewgait andrewgait added the minor Not especially important. Might be cleanup activity, etc. label Apr 22, 2021
@andrewgait andrewgait added this to the 7.0.0 milestone Apr 22, 2021
@rowleya
Copy link
Member

rowleya commented Apr 23, 2021

This looks fine - just a thought that we should maybe also pylint spynnaker8?

@andrewgait
Copy link
Contributor Author

This looks fine - just a thought that we should maybe also pylint spynnaker8?

Don't see why not - will add it.

@rowleya rowleya merged commit ff30858 into master May 6, 2021
@rowleya rowleya deleted the flake8_tidy_up branch May 6, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Not especially important. Might be cleanup activity, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants