Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key translation #1138

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Key translation #1138

merged 5 commits into from
Dec 6, 2021

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented Dec 1, 2021

Update to make use of Key Translation from SpiNNakerManchester/SpiNNFrontEndCommon#901 and add an example.

Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though as it's adding a new test I'd suggest running an integration test branch as well just to be safe.

@rowleya
Copy link
Member Author

rowleya commented Dec 2, 2021

You were right to request this - the test is indeed failing although I am struggling to work out why since it works for me... Further investigation is in progress

@rowleya
Copy link
Member Author

rowleya commented Dec 6, 2021

@andrewgait andrewgait merged commit afea579 into master Dec 6, 2021
@rowleya rowleya deleted the key_translation branch June 6, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants