-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining code from spynnaker8 #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last of the code from the spynnaker8 directory.
Changes include.
spynnaker8 is no longer being documented.
spynnaker8 init file moved to spynnaker.pynn
spynnaker8.external_devices init moved to spynnaker/pyNN/external_devices
spynnaker8.extra_models moved to spynnaker/pyNN/external_devices
The above three files replaced with redirect hook files which will war in Version 7 and error in 8
spynnaker8 init will detect if it is called by import spynnaker8 or import pynn.spinnaker
- in the first is warns that a change is needed
- in the second it runs setup_pynn and errors asking to run again
added
spynnaker.pynn.setup_pynn
- note could not be under just spynnaker as the the import pyNN gets confused
Code that was deprecated in version 6 will now error.
abstract_spinnaker_common.py has been merged into spinnaker.py
spinnaker.py also moved to spynnaker/pyNN
abstract_spinnaker_common.py has been replaced with a redirect hook for the one static method called elsewhere.
test with http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/remove_8/6/pipeline
(which was before upstream changes pushed)
spynnaker8/utilities/neo_convertor.py one method in deprecated class did not log. It now errors.
tests changed to moved stuff
Note: the original spynnaker8 setup_pynn I an unsure about.
I suggest doing that in a later PR but before the release
--
These PRs adapt to the removal of abstract_spinnaker_common.py
Note: global_data_new_pr do it a different way so these are only needed if that is refused.
SpiNNakerManchester/sPyNNakerNewModelTemplate#84
SpiNNakerManchester/SpiNNGym#42
tested by:
#1163