Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spinnaker_get_data #1179

Merged
merged 4 commits into from
May 19, 2022
Merged

spinnaker_get_data #1179

merged 4 commits into from
May 19, 2022

Conversation

Christian-B
Copy link
Member

spinnaker_get_data now has an extra optional bool param as_matrix
If set will return V as a 2d matric ids * timestamps, (Without headers)

spinnaker_get_data enabled on views

better error with spinnaker_get_data("rewirings")

remove message that spinnaker_get_data may not be supported.

Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - is it tested?

@Christian-B
Copy link
Member Author

Christian-B commented May 17, 2022

Jenkins branch created

@andrewgait andrewgait merged commit 40adc33 into master May 19, 2022
@andrewgait andrewgait deleted the spinnaker_view branch May 19, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants