Allow STDP on self-projections #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowleya
requested changes
Jun 7, 2022
...r/pyNN/extra_algorithms/splitter_components/splitter_abstract_pop_vertex_neurons_synapses.py
Outdated
Show resolved
Hide resolved
rowleya
approved these changes
Jun 8, 2022
...r/pyNN/extra_algorithms/splitter_components/splitter_abstract_pop_vertex_neurons_synapses.py
Show resolved
Hide resolved
|
This change looks fine - happy for this to be merged if ready |
I think I'd prefer to leave this on a branch for now while I investigate the neuromodulation aspect a bit further - that's still not behaving the same when a splitter is used compared to when it isn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1186 for both neuromodulated and non-neuromodulated STDP.
[Previous comment: Discussions of https://github.com//issues/1186 via Skype highlighted that there were also problems with non-neuromodulated STDP on self-projections. This fixes those cases but there still remain issues when the STDP is neuromodulated, for which discussions and investigations are ongoing.]
Tested by SpiNNakerManchester/IntegrationTests#122