Use the new provenance reporting API where possible #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alas, PopulationMachineVertex can't do it; it wants to examine the standard provenance info as well as the PMV-specific fields. See SpiNNakerManchester/SpiNNFrontEndCommon#681
Change the methods that convert arrays of prov data into provenance items to be named “parse_…” for clarity. And used more public names. And audited what are actually using so uncalled methods are no longer there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nice part of this is that we can just
yieldthe provenance items and the common code packages everything up nicely. It's Python magic that makes things easier to read.Alas, PopulationMachineVertex can't do it; it wants to examine the standard provenance info as well as the PMV-specific fields. While it would have been possible to hack it to make it work, the result would be ghastly. Overriding everything is just so much simpler.
See SpiNNakerManchester/SpiNNFrontEndCommon#681