Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Add publish vscode extension step to release workflow #1423

Merged
merged 2 commits into from
Jun 30, 2024
Merged

🔧 Add publish vscode extension step to release workflow #1423

merged 2 commits into from
Jun 30, 2024

Conversation

misode
Copy link
Member

@misode misode commented Jun 30, 2024

@misode misode requested a review from SPGoding June 30, 2024 04:38
SPGoding
SPGoding reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@SPGoding SPGoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move the release commands to the release script in packages/vscode-extension, so they all get run by npm run release at root? The commands and environmental variables look good to me.

@misode misode merged commit 0d3957d into SpyglassMC:main Jun 30, 2024
3 checks passed
@misode misode deleted the publish-vscode-extension-ci branch June 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPGoding SPGoding SPGoding left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misode @SPGoding