🔥 Remove IndexMap.merge #1486
Merged
🔥 Remove IndexMap.merge #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TheAfroOfDoom
approved these changes
Jul 8, 2024
this was also my expected solution, given a cleaner IndexMap.merge method not yet existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexMap.merge, it's not needed and was broken anywaysThis fix likely makes the string parser a lot slower, because it needs to compute the outer cursor for every character. There is likely a more efficient way of combining the relevant index map pairs of the src indexMap, but that seems tricky to implement.