✨ Validate leading slash in command attribute #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MulverineX
reviewed
Jul 8, 2024
SPGoding
approved these changes
Jul 8, 2024
MulverineX
approved these changes
Jul 8, 2024
NeunEinser
reviewed
Jul 8, 2024
| })(src, ctx) | ||
| } | ||
| return mcf.command(rootTreeNode, parser.argument, { | ||
| slash: slash === 'chat' ? 'allowed' : slash, |
There was a problem hiding this comment.
If it's chat as in a /tellraw component, a slash is actually required (without the slash, it used to just send a chat message in your name, but I think since the chat signing thing, it's just disallowed).
On signs however, a slash is optional.
If the aim is not to 100% solve these cases, the linked issue as wrong, as it describes a v3 bug where DPH+ would show an error when omitting the slash on a sign.
There was a problem hiding this comment.
Hmm so on signs in the run_command action, it will run the command when you don't start with a slash?
If that's the case I don't immediately see an easy way to fix this, so I'd rather just move the issue to backlog.
NeunEinser
reviewed
Jul 8, 2024
NeunEinser
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.