Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ provide exclude patterns to file watcher args #1607

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

⚡️ provide exclude patterns to file watcher args #1607

wants to merge 5 commits into from
+54 −5

Commits on Sep 27, 2024

  1. 🐛 parse .gitignore into individual paths for exclude logic

    @TheAfroOfDoom
    TheAfroOfDoom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4f36ed9 View commit details
    Browse the repository at this point in the history

  2. ⚡️ pass exclude config to chokidar

    @TheAfroOfDoom
    TheAfroOfDoom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    50dc305 View commit details
    Browse the repository at this point in the history

  3. 🚸 process exclude paths after parsing 

    - known pitfall of chokidar described in the comment. we can help users avoid this easy mistake
    @TheAfroOfDoom
    TheAfroOfDoom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    370c3aa View commit details
    Browse the repository at this point in the history

  4. 🔧 change default exclude to ignore all dot files 

    - i think in the vast majority of cases, users won't want us parsing any files in there (.git, .yarn, ...)
    @TheAfroOfDoom
    TheAfroOfDoom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    abd7e4f View commit details
    Browse the repository at this point in the history

  5. 🐛 allow for absolute exclude paths 

    - useful for excluding a project root that is only for references and Spyglass doesn't need to parse
- windows made this a pain, but it works for me locally; i can specify an absolute path (e.g. a workspace root i want to exclude) and the watcher skips the root's files.
- making it case-insensitive for windows was the annoying part
    @TheAfroOfDoom
    TheAfroOfDoom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7c97718 View commit details
    Browse the repository at this point in the history