ERR wrong number of arguments for 'sadd' command

[omeaart]

Not entirely sure if this is expected behaviour, but it surprised me. When the SetAdd(Async) methods are used with an empty array of values, there is a broken call made to redis.

To reproduce:

var redisConnection = ConnectionMultiplexer.Connect("localhost");
redisConnection.GetDatabase().SetAdd("set1", new RedisValue[0]);

This also fails for SetAddAsync.

Version: 2.0.601
Tested with dotnetcore 2.2 and 3.0

[mgravell]

Agreed - we should detect that and no-op it (avoiding the redis call completely, whenever possible)

…

On Tue, 19 Nov 2019, 05:00 Aart Jan Kaptijn, ***@***.***> wrote: Not entirely sure if this is expected behaviour, but it surprised me. When the SetAdd(Async) methods are used with an empty array of values, there is a broken call made to redis. To reproduce: var redisConnection = ConnectionMultiplexer.Connect("localhost"); redisConnection.GetDatabase().SetAdd("set1", new RedisValue[0]); This also fails for SetAddAsync. Version: 2.0.601 Tested with dotnetcore 2.2 and 3.0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1282?email_source=notifications&email_token=AAAEHMGKIVG6QHRE53W4BP3QUPBMJA5CNFSM4JPBSQGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2J3ZJQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEHMARI3ORVBLCW7NBTUTQUPBMJANCNFSM4JPBSQGA> .

[omeaart]

This was resolved in #1283