Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams Transaction Issue #2167

Closed
askoutaris opened this issue Jun 21, 2022 · 2 comments
Closed

Streams Transaction Issue #2167

askoutaris opened this issue Jun 21, 2022 · 2 comments

Comments

@askoutaris
Copy link

askoutaris commented Jun 21, 2022

All methods inside RedisDatabase.cs which call ExecuteAsync with parameter 'T defaultValue' (eg StreamReadGroupAsync) does not work with transactions since there is no override ExecuteAsync with parameter 'T defaultValue' in RedisTransaction.cs and as a result ExecuteAsync of RedisBase.cs is used instead of RedisTransaction.cs

FYI: I downloaded the code and managed it to work by adding the overriden methods shown in the attached screenshot.

2022-06-21 17_49_48-RedisStreams - Microsoft Visual Studio Preview

@mgravell
Copy link
Collaborator

agreed, this looks like a problem; do you have any concrete examples of failure cases here? honestly, the best thing is probably to submit this as a PR including tests

@askoutaris
Copy link
Author

Thank you for your feedback!
I'll try to find some time in the next days to study and follow all Github's procedures about branching and PR policies in order to help you with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants