Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TOUCH command #1291

Merged
merged 12 commits into from
Feb 3, 2020
Merged

Add support for TOUCH command #1291

merged 12 commits into from
Feb 3, 2020

Conversation

gkorland
Copy link
Contributor

Fix #1278

@gkorland gkorland marked this pull request as ready for review November 28, 2019 14:06
@gkorland
Copy link
Contributor Author

gkorland commented Dec 2, 2019

@mgravell I managed to clean the Linux tests but on windows I'm getting this error
StackExchange.Redis.RedisServerException : ERR unknown command 'TOUCH'.

Is there a plan to upgrade the Redis version on windows behind 3.0.503?

@mgravell
Copy link
Collaborator

mgravell commented Dec 2, 2019

The problem there is that redis-64 was abandoned sometime around V3.

The simple fix here is to just to use server version detection in the code, and if TOUCH isn't expected : either don't test it, or assert that it fails in this way. Lots of tests do similar.

For the other fix on Windows, though is for us to do one of 3 things:

  • use an external Linux server
  • use WSL/WSL2
  • use the more recent code that fell out of redis-64 (can't recall the name off-hand, but it exists, but isn't totally F/OSS)

Probably best to just use server version detection for now :)

@gkorland
Copy link
Contributor Author

gkorland commented Dec 4, 2019

Probably best to just use server version detection for now :)
Ok I'll do it, BTW there are much newer versions for Redis on Windows 4.x and I saw there is already a work in progress to support 5.0.6

@mgravell
Copy link
Collaborator

mgravell commented Dec 4, 2019

are you referrring to Memurai? or...?

@gkorland
Copy link
Contributor Author

gkorland commented Dec 8, 2019

@gkorland
Copy link
Contributor Author

gkorland commented Dec 8, 2019

@mgravell added the server feature test

@mgravell mgravell merged commit faf931d into StackExchange:master Feb 3, 2020
@gkorland
Copy link
Contributor Author

gkorland commented Feb 4, 2020

@mgravell thanks,

@ejsmith ejsmith mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a friendly way to run the "TOUCH" command
2 participants