Improving ConfigCheckSeconds for a faster failover detection #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a master node disconnect performs ConfigCheckSeconds on replica nodes with an exponential backoff
NickCraver
requested changes
May 25, 2021
|
|
||
|
|
||
| // Forces frequent replication check starting from 1 second upto max ConfigCheckSeconds with an exponential increment | ||
| internal void ForceExponentiallyReplicationCheck() |
There was a problem hiding this comment.
Can we rename this for clarity please?
Suggested change
| internal void ForceExponentiallyReplicationCheck() | |
| internal void ForceExponentialBackoffReplicationCheck() |
philon-msft
approved these changes
May 25, 2021
NickCraver
approved these changes
May 26, 2021
NickCraver
changed the title
NickCraver
pushed a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes info command storm on a disconnect
After a master node disconnect performs ConfigCheckSeconds on replica nodes with an exponential backoff