Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CommandMap check before requesting cluster nodes #2014

Merged
merged 6 commits into from
Feb 26, 2022
Merged

Added CommandMap check before requesting cluster nodes #2014

merged 6 commits into from
Feb 26, 2022

Conversation

tylerohlsen
Copy link
Contributor

Fixes #2012

@tylerohlsen
Copy link
Contributor Author

tylerohlsen commented Feb 25, 2022

Interesting that this failed with Envoy proxy. It looks like Envoy does actually support RedisCommand.CLUSTER even though their documentation doesn't list it. So should I remove that from the exclusions here?

/// <summary>
/// The commands available to <a href="https://github.com/envoyproxy/envoy">envoyproxy</a>.
/// </summary>
public static CommandMap Envoyproxy { get; } = CreateImpl(null, exclusions: new HashSet<RedisCommand>
{
// see https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_protocols/redis.html?highlight=redis
RedisCommand.KEYS, RedisCommand.MIGRATE, RedisCommand.MOVE, RedisCommand.OBJECT, RedisCommand.RANDOMKEY,
RedisCommand.RENAME, RedisCommand.RENAMENX, RedisCommand.SORT, RedisCommand.SCAN,
RedisCommand.BITOP, RedisCommand.MSETNX,
RedisCommand.BLPOP, RedisCommand.BRPOP, RedisCommand.BRPOPLPUSH, // yeah, me neither!
RedisCommand.PSUBSCRIBE, RedisCommand.PUBLISH, RedisCommand.PUNSUBSCRIBE, RedisCommand.SUBSCRIBE, RedisCommand.UNSUBSCRIBE,
RedisCommand.DISCARD, RedisCommand.EXEC, RedisCommand.MULTI, RedisCommand.UNWATCH, RedisCommand.WATCH,
RedisCommand.SCRIPT,
RedisCommand.ECHO, RedisCommand.QUIT, RedisCommand.SELECT,
RedisCommand.BGREWRITEAOF, RedisCommand.BGSAVE, RedisCommand.CLIENT, RedisCommand.CLUSTER, RedisCommand.CONFIG, RedisCommand.DBSIZE,
RedisCommand.DEBUG, RedisCommand.FLUSHALL, RedisCommand.FLUSHDB, RedisCommand.INFO, RedisCommand.LASTSAVE, RedisCommand.MONITOR, RedisCommand.REPLICAOF,
RedisCommand.SAVE, RedisCommand.SHUTDOWN, RedisCommand.SLAVEOF, RedisCommand.SLOWLOG, RedisCommand.SYNC, RedisCommand.TIME,
// supported by envoy but not enabled by stack exchange
// RedisCommand.BITFIELD,
//
// RedisCommand.GEORADIUS_RO,
// RedisCommand.GEORADIUSBYMEMBER_RO,
});

@NickCraver
Copy link
Collaborator

@tylerohlsen this wasn't you - had a fix pending in #2011. Just merged to bringing main to your branch should help. I think for this PR we should just add a test with it disabled, e.g. a DisabledCommandsStillConnectCluster beside the existing DisabledCommandsStillConnect - thoughts?

@tylerohlsen
Copy link
Contributor Author

I think for this PR we should just add a test with it disabled, e.g. a DisabledCommandsStillConnectCluster beside the existing DisabledCommandsStillConnect - thoughts?

I certainly can. That might take me a bit longer.

@NickCraver
Copy link
Collaborator

@tylerohlsen I gotcha - pushing up a test and release notes!

Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @tylerohlsen!

@NickCraver NickCraver merged commit 65c1f28 into StackExchange:main Feb 26, 2022
@tylerohlsen
Copy link
Contributor Author

Awesome! Thanks @NickCraver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignalR backplane with disabled CLUSTER command generates hundreds of connection errors
2 participants