Support the ZMSCORE command. #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
requested changes
Apr 12, 2022
|
@NickCraver all done with the requested changes. Let me know if there is anything else. |
|
@ttingen Made a few quick changes to normalization and naming (I see why keys in tests were confusing where above we did need 2 unique keys - sorry about that!) - will try to do a top-down review in a bit! |
NickCraver
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
@ttingen I think current is good - thank you! I'd appreciate @slorello89 eyes here when time allows.
|
@slorello89 @Avital-Fine Can one of y'all provide secondary eyes here please? |
slorello89
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Somehow missed the request @NickCraver sorry about that! LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/commands/zmscore/
#2055