-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LCS #2104
Support LCS #2104
Conversation
@NickCraver Hey! |
@Avital-Fine, fixed the API declarations |
"Match" in .NET is usually RegEx match - let's remove some pain here and tidy up
@Avital-Fine I gave this some tidy love this morning, but gotta change gears a lot today. I think at the moment all this needs is more testing around missing key cases (1 or both) and non-matches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current looks good - thanks for iterating on this crazy command :)
https://redis.io/commands/lcs/
#2055