-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IAsyncDisposable from IConnectionMultiplexer #2161
Conversation
Hey @kimsey0 - we should add release notes and move the API to the Shipped set in-order but then good to go. Happy to take care of that to get this in if you want :) |
7a829f0
to
5b086e6
Compare
@NickCraver: I moved the API change to shipped and added a new line under Unreleased in the release notes document. I haven't used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! 1 issue introduced with a null ref in dispose though - need to shuffle a bit on how that's handled (comments inline).
Co-authored-by: Nick Craver <nrcraver@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you!
Thanks! |
Fixes #2160.
We may want to implement
IAsyncDisposable
in more publicIDisposable
classes which can dispose their resources asynchronously.