Support HeartbeatConsistencyChecks in Clone()
#2658
Merged
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sooooooo I think I missed this because interval isn't in there either… |
|
Thoughts on some reflection-based test for clone checking to prevent future misses? |
added; I have no great ideas on the reflection thing - feel free to suggest |
|
maybe just a count of the fields on Assert.Equals(43, fields.Length); // if this fails, check Clone() has been updated |
|
+1 I like it - simple and effective we can get fancier if ever justified. Do you mind adding in this PR please? If slammed I can follow-up later in day too. |
|
@NickCraver already working on it |
|
@NickCraver see 2a624a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release 2.7.23 added a
ConfigurationOptions.HeartbeatConsistencyChecksoption, but that option is not represented inClone(); fix that