-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to pass in encrypted key/values into the CLI and API #4547
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
800fe97
Added ability to pass in encrypted values into the CLI and API then d…
nmaludy 559f7ce
Merge remote-tracking branch 'upstream/master' into feature/kvp-cli-a…
nmaludy 80fe135
Merge branch 'master' into feature/kvp-cli-api-decrypt
nmaludy 247e51c
Merge branch 'master' into feature/kvp-cli-api-decrypt
nmaludy d6fd8c8
Merge branch 'master' into feature/kvp-cli-api-decrypt
Kami 820b809
Throw an error if we fail to decrypt a value when working with a
Kami 9a8d1fd
Per discussion with @nmaludy on Slack, make the following changes:
Kami 677c4b4
Add changelog entry.
Kami 5228fa7
Update "st2 key load" CLI command so it works out of the box with values
Kami 4f6fa27
Update changelog.
Kami ddd1514
Update test cases to test the new behavior, verify there is no
Kami 8e34d21
Re-generate openapi file.
Kami 970b3eb
Make --encrypt and --pre-encrypt arguments mutually exclusive.
Kami 88607e3
Change attribute and CLI flag name from "--pre-encrypted" to "--encry…
Kami b77e98a
Use "parser.add_mutually_exclusive_group".
Kami 17427bf
Add a test case for a failed integrity check.
Kami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed it but I don't see a unit test that shows failure in checking integrity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - I did plan to add that one, but forgot to.
Will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 17427bf.