add support for render layers on tilemaps #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Given two cameras with bevy's builtin
RenderLayer
component:And a tilemap set to one of those render layers:
The tilemap should render on ONLY the specified camera, but it will render on both. PR is to correct this behavior.
Impl:
Existing logic respects the value of
ComputedVisibility
for a visibility check, but my understanding is thatComputedVisibility
is based on the entity's visibility to anyCamera
. Each camera maintains aVisibleEntities
component, containing a list of entities visible to that particular camera. The change is to skip queuing chunks of tilemaps that are not visible to the iterated view.Let me know if you think there is a more sensible or complete way to do this. Or if it is already addressed somewhere else that I've overlooked 😄