Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused section from Cargo.toml #361

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

rparrett
Copy link
Collaborator

Fixes this warning seen when running any example

warning: unused manifest key: target.wasm32-unknown-unknown.runner

As noted here: https://github.com/jakobhellermann/wasm-server-runner#step-2 this only works in an individual's cargo config.

@bzm3r
Copy link
Collaborator

bzm3r commented Nov 29, 2022

Big if true! Has this been tested with: https://github.com/StarArawn/bevy_ecs_tilemap#running-examples-on-web

@rparrett
Copy link
Collaborator Author

rparrett commented Nov 29, 2022

Those instructions do continue to work. The removed section is completely superfluous / doing nothing for us.

However, wasm-server-runner really shines when configured as described in the link above. If configured properly, the second command isn't necessary at all. Cargo will use the configured runner automatically and all you have to do is (note: run instead of build)

cargo run --target wasm32-unknown-unknown --example animation --release --features atlas

I added a commit that improves the instructions.

If wasm-server-runner is installed and configured, there is no need
to invoke it manually. And it would be nice to link users to the
instructions for installing it.
@StarArawn StarArawn merged commit eb20fca into StarArawn:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants