Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with z-index by hiding the y-sort behind a flag. #408

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

StarArawn
Copy link
Owner

No description provided.

@StarArawn StarArawn requested a review from rparrett March 28, 2023 01:19
@rparrett
Copy link
Collaborator

I like this change, but it's unfortunate that it's a breaking change.

I personally feel like the right call might be to remove the y-sorting for a 0.10.1 release and then do this in the main branch / for an eventual 0.11. I think that would work out better for most people. Very few should be relying on it right now, and it seems to be broken in some cases anyhow.

@StarArawn
Copy link
Owner Author

I like this change, but it's unfortunate that it's a breaking change.

I personally feel like the right call might be to remove the y-sorting for a 0.10.1 release and then do this in the main branch / for an eventual 0.11. I think that would work out better for most people. Very few should be relying on it right now, and it seems to be broken in some cases anyhow.

Yeah, I was thinking maybe it was okay to sneak by, but anyone using TilemapRenderSettings would probably get a little upset.

src/map/mod.rs Show resolved Hide resolved
Co-authored-by: Rob Parrett <robparrett@gmail.com>
@StarArawn StarArawn merged commit d15f332 into main Mar 28, 2023
@StarArawn StarArawn deleted the fix-z-index branch March 28, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants