-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NamedTempFile::persist_noclobber panicks on Android #259
Closed
Comments
cc @sunfishcode |
sunfishcode
added a commit
to bytecodealliance/rustix
that referenced
this issue
Oct 23, 2023
When `renameat_with` is passed non-zero flags, fall back to the `syscall!` macro on ABIs such as Android where libc has a `renameat` but not a `renameat2`. Fixes Stebalien/tempfile#259.
Thanks for the report! I've now submitted bytecodealliance/rustix#892 with a fix. |
sunfishcode
added a commit
to bytecodealliance/rustix
that referenced
this issue
Oct 23, 2023
When `renameat_with` is passed non-zero flags, fall back to the `syscall!` macro on ABIs such as Android where libc has a `renameat` but not a `renameat2`. Fixes Stebalien/tempfile#259.
The rustix bug here is now fixed in rustix 0.38.21. |
Woot - android CI is now passing sans-workaround. Thanks @sunfishcode 🙌 - closing this. |
Stebalien
added a commit
that referenced
this issue
Oct 26, 2023
This was referenced Oct 26, 2023
Stebalien
added a commit
that referenced
this issue
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to this assertion in rustix: https://github.com/bytecodealliance/rustix/blob/v0.38.3/src/backend/libc/fs/syscalls.rs#L511
The text was updated successfully, but these errors were encountered: