Clean up unwrap #29
Merged
Clean up unwrap #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless I'm mistaken, this only existed to ensure that Terminal is object safe. However, it's now possible to specify `Self: Sized` on methods to exclude them from objects so the extra trait should be unnecessary. [breaking-change]
Convention. [breaking-change]
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UnwrappableTerminal trait and rename unwrap to into_inner. As far as I
know, the trait existed to make Terminal object safe but that's no longer an
issue as one can specify
Self: Sizedon object unsafe methods.