Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip InetUtils tests on hosted Mac, target netcoreapp3.1 #354

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jun 16, 2020

Several tests recently started failing on MacOS CI builds though no Steeltoe code changed, this PR skips those on Mac
Also:

  • updates dependencies and tests to use netcoreapp3.1 instead of netcoreapp3.0
  • .csproj and pipeline maintenance

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #354 into 2.x will increase coverage by 3.54%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #354      +/-   ##
==========================================
+ Coverage   71.34%   74.89%   +3.54%     
==========================================
  Files         819      714     -105     
  Lines       23380    20344    -3036     
  Branches     4262     3447     -815     
==========================================
- Hits        16681    15236    -1445     
+ Misses       5530     4186    -1344     
+ Partials     1169      922     -247     
Impacted Files Coverage Δ
...Common/src/Common.Hosting/HostBuilderExtensions.cs 90.47% <ø> (ø)
...udFoundryCore/CloudFoundryHostBuilderExtensions.cs 55.55% <ø> (ø)
.../ConfigServerConfigurationBuilderExtensionsCore.cs 88.23% <ø> (ø)
...intCore/Env/EndpointServiceCollectionExtensions.cs 69.23% <ø> (ø)
...ngBootAdminClient/BootAdminAppBuilderExtensions.cs 81.63% <ø> (ø)
...yForwarder/EndpointApplicationBuilderExtensions.cs 0.00% <ø> (ø)
...pkin/ZipkinExporterApplicationBuilderExtensions.cs 0.00% <ø> (ø)
...ipkin/ZipkinExporterServiceCollectionExtensions.cs 89.28% <ø> (ø)
...hentication.CloudFoundryBase/CloudFoundryHelper.cs 74.07% <ø> (ø)
...ation.CloudFoundryCore/CloudFoundryOAuthHandler.cs 80.18% <ø> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151f3d2...05c98ac. Read the comment docs.

@TimHess TimHess requested review from hananiel, dtillman and jkonicki and removed request for hananiel June 16, 2020 16:20
@TimHess TimHess added ReleaseLine/2.x Identified as a feature/fix for the 2.x release line Type/infrastructure labels Jun 16, 2020
@TimHess TimHess added this to the 2.5.0-RC1 milestone Jun 16, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

72.0% 72.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess self-assigned this Jun 16, 2020
@TimHess
Copy link
Member Author

TimHess commented Jun 16, 2020

Our test failures seem to be caused by this issue, revisit after azure pipelines get the update (next week?)

@TimHess TimHess merged commit ba85150 into 2.x Jun 17, 2020
@TimHess TimHess deleted the netcoreapp3_1 branch June 17, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/2.x Identified as a feature/fix for the 2.x release line Type/infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants