easy optimisation

Stephane-D · Jul 2, 2024 · 9daa5f0 · 9daa5f0
1 parent bdfe187
commit 9daa5f0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/lib/libmd.a b/lib/libmd.a
diff --git a/lib/libmd_debug.a b/lib/libmd_debug.a
diff --git a/src/sprite_eng.c b/src/sprite_eng.c
@@ -1473,7 +1473,7 @@ void NO_INLINE SPR_update()
             s8 numSprite = frame->numSprite;
 
             // special case of single VDP sprite with size aligned to sprite size (no offset, no flip calculation required)
-            if (numSprite == -1)
+            if (numSprite < 0)
             {
                 vdpSprite->y = sprite->y;
                 vdpSprite->size = frameSprite->size;
@@ -1743,7 +1743,7 @@ static u16 updateVisibility(Sprite* sprite, u16 status)
             s8 num = frame->numSprite;
 
             // special case of single VDP sprite with size aligned to sprite size (no offset, no flip calculation required)
-            if (num == -1) visibility = ((bx < mx) && (by < my))?0x8000:0;
+            if (num < 0) visibility = ((bx < mx) && (by < my))?0x8000:0;
             else
             {
                 FrameVDPSprite* frameSprite = frame->frameVDPSprites;

diff --git a/src/sprite_eng_legacy.c b/src/sprite_eng_legacy.c
@@ -1746,7 +1746,7 @@ static u16 updateVisibility(Sprite* sprite, u16 status)
         else if ((xmax < 0) || ((xmin - fw) > 0)) visibility = VISIBILITY_OFF;
         else
         {
-            u16 num = (frame->numSprite == -1)?1:frame->numSprite;
+            u16 num = (frame->numSprite < 0)?1:frame->numSprite;
             // start from the last one
             FrameVDPSprite* frameSprite = &(frame->frameVDPSprites[num]);
             visibility = 0;
@@ -1846,7 +1846,7 @@ static u16 updateFrame(Sprite* sprite, u16 status)
     }
 
     // detect if we need to hide some VDP sprite
-    s16 currentNumSprite = (frame->numSprite == -1)?1:frame->numSprite;
+    s16 currentNumSprite = (frame->numSprite < 0)?1:frame->numSprite;
 
     // adjust number of sprite to hide
     sprite->spriteToHide += sprite->lastNumSprite - currentNumSprite;
@@ -1902,7 +1902,7 @@ static void updateSpriteTableAll(Sprite* sprite)
     visibility = sprite->visibility;
     attr = sprite->attribut;
     frame = sprite->frame;
-    num = (frame->numSprite == -1)?1:frame->numSprite;
+    num = (frame->numSprite < 0)?1:frame->numSprite;
     frameSprite = frame->frameVDPSprites;
     vdpSprite = &vdpSpriteCache[sprite->VDPSpriteIndex];
 
@@ -1990,7 +1990,7 @@ static void updateSpriteTablePos(Sprite* sprite)
     visibility = sprite->visibility;
     attr = sprite->attribut;
     frame = sprite->frame;
-    num = (frame->numSprite == -1)?1:frame->numSprite;
+    num = (frame->numSprite < 0)?1:frame->numSprite;
     frameSprite = frame->frameVDPSprites;
     vdpSprite = &vdpSpriteCache[sprite->VDPSpriteIndex];
 
@@ -2063,7 +2063,7 @@ static void updateSpriteTableHide(Sprite* sprite)
 
     VDPSprite* vdpSprite = &vdpSpriteCache[sprite->VDPSpriteIndex];
     // don't forget to hide sprites that were used by previous frame
-    s16 num = (frame->numSprite == -1)?1:frame->numSprite;
+    s16 num = (frame->numSprite < 0)?1:frame->numSprite;
 
     if (sprite->spriteToHide > 0) num += sprite->spriteToHide;