Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make module loading compatible with requirejs when used with electron. #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

docnoe
Copy link

@docnoe docnoe commented Jul 31, 2015

Just switches the order of module loading scenarios.

This change only has an effect on apps that are build with electron or nw.js in combination with the require.js optimizer. The problem with these apps is that they share the "require" statement of node.js with the front end, which then collides with the "require" statement of require.js.
Although it is possible to define a different namespace during r.js optimization, knockout and ko-projections will throw some funny errors.
This is only way I got it to work, combined with some other hacky stuff.

I fell in love with your yeoman generator for knockout and really don't want to switch to angular or any other hyped framework to be able to build electron/hybrid apps.

Just switches the order of module loading scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant