Improve parsing Issues reporting
#74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve Strumenta#59 Inspired by [Strumenta/kolasu#292](Strumenta/kolasu#292). - `Issue`'s messages are now capitalized to improve readability. - `Position`'s `isEmpty` method has been safely renamed to `isFlat` to match the [convention used in kolasu](https://github.com/Strumenta/kolasu/blob/0676131e403718d2d99c792dc0a81a87bd48a34f/ast/src/commonMain/kotlin/com/strumenta/kolasu/model/Point.kt#L136). This ensures consistency across the StarLasu collection. The `isEmpty` method has now been deprecated and is to be removed in the future. - Parsing `Issue`s report the correct `Position` by taking into consideration the length of the token, to improve UX.
Mochitto
force-pushed
the
feat/better-issues
branch
from
878ee1a
to
57f2b15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #59
Inspired by Strumenta/kolasu#292.
Issue's messages are now capitalized to improve readability.Position'sisEmptymethod has been safely renamed toisFlatto match the convention used in kolasu. This ensures consistency across the StarLasu collection. TheisEmptymethod has now been deprecated and is to be removed in the future.Issues report the correctPositionby taking into consideration the length of the token, to improve UX.The above message has been included in the commit's description.
Test coverage has been extended to the new features.
The changelog has been updated to reflect the changes, with the version
Unreleasedto facilitate library moderation.