enable selector-specific stdin filename for buffers #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dndrsn
force-pushed
the
selector-specific-buffer-filename
branch
from
d75c8c3
to
140e691
Compare
|
FYI. Added comment to disable linter error on line 25. This appears to be a preexisting issue. It's unclear to me what the purpose of this line is. |
dndrsn
force-pushed
the
selector-specific-buffer-filename
branch
from
140e691
to
380be4c
Compare
kaste
reviewed
Dec 29, 2022
kaste
reviewed
Dec 29, 2022
kaste
reviewed
Dec 29, 2022
kaste
reviewed
Dec 29, 2022
kaste
reviewed
Dec 29, 2022
kaste
requested changes
Dec 29, 2022
dndrsn
force-pushed
the
selector-specific-buffer-filename
branch
from
380be4c
to
2be661f
Compare
kaste
reviewed
Dec 30, 2022
kaste
requested changes
Dec 30, 2022
dndrsn
force-pushed
the
selector-specific-buffer-filename
branch
from
7653f3a
to
ad8dbe1
Compare
|
Let's do this. LGTM. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to use selector specific dummy filenames for unsaved buffers. Replaces dummy filenames with "stdin" when parsing linter output in the same manner that is currently implemented for "".
Also includes the addition of plugin support for 2 common YAML plugins. These additions are not core to this change, but are related and necessary to add dummy file extension support for YAML.
A further improvement to this change would be to move the mapping of selectors to file extensions to the config file, but because this is closely coupled to the plugins config, it would make sense to move both to the config file (if possible) at the same time.