fix: Change DEBUG=True by default to DEBUG=False (#757)

* fix: Change `DEBUG=True`  by default to `DEBUG=False`

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>

* docs: changelog

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>

---------

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>

CHANGELOG.md

@@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Pre-populate Skaffold deployment with substra-tools base docker image (not minimal) ([#736](https://github.com/Substra/substra-backend/pull/736))
 
+### Fixed
+
+- `settings.DEBUG` is not `True` by default.
+
 ## [0.42.0](https://github.com/Substra/substra-backend/releases/tag/0.42.0) 2023-09-08
 
 ## Changed

backend/backend/settings/common.py

@@ -23,8 +23,7 @@
 from .deps.path import *
 from .deps.utils import to_bool
 
-# SECURITY WARNING: don't run with debug turned on in production!
-DEBUG = True
+DEBUG = False
 
 
 SUBPATH = os.environ.get("SUBPATH", "")  # prefix for backend endpoints

backend/backend/settings/localdev.py

@@ -1,6 +1,8 @@
 from .mods.oidc import *
 from .test import *
 
+DEBUG = True
+
 # Enable Browsable API
 REST_FRAMEWORK["DEFAULT_RENDERER_CLASSES"] += ("rest_framework.renderers.BrowsableAPIRenderer",)
 REST_FRAMEWORK["DEFAULT_AUTHENTICATION_CLASSES"] += [

backend/backend/settings/prod.py

@@ -9,8 +9,6 @@
 from .mods.cors import *
 from .mods.oidc import *
 
-DEBUG = False
-
 USE_X_FORWARDED_HOST = True
 SECURE_PROXY_SSL_HEADER = ("HTTP_X_FORWARDED_PROTO", "https")
 os.environ["HTTPS"] = "on"

backend/backend/settings/test.py

@@ -8,6 +8,8 @@
 
 logging.disable(logging.CRITICAL)
 
+DEBUG = True
+
 ORG_NAME = "OrgTestSuite"
 DEFAULT_DOMAIN = "http://testserver"
 ALLOWED_HOSTS = ["testserver"]

backend/backend/settings/worker/events/dev.py

@@ -1 +1,3 @@
 from .common import *
+
+DEBUG = True