Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skaffold profile three orgs #975

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Aug 19, 2024

Description

Fixes FL-1705

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Copy link

linear bot commented Aug 19, 2024

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes marked this pull request as ready for review August 19, 2024 15:24
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner August 19, 2024 15:24
@ThibaultFy
Copy link
Member

/e2e --tests docs

To test, these are the e2e tests that are using this profile

@Owlfred
Copy link

Owlfred commented Aug 19, 2024

End to end tests: ❌ FAILURE

Jobs status:

Better luck next time!

@guilhem-barthes
Copy link
Contributor Author

guilhem-barthes commented Aug 19, 2024

Ok, so we have the three-orgs profile that does not support last version from skaffold, while the other profiles are not compatible with the previous version. Which skaffold version should be supported?

@ThibaultFy
Copy link
Member

Ok, so we have the three-orgs profile that does not support last version from skaffold, while the other profiles are not compatible with the previous version. Which skaffold version should be supported?

I guess the latest possible ? Is it possible to upgrade the three orgs profile to match the latest skaffold ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants