Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run macOsWorkaround() on macOS #206

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

heksesang
Copy link
Contributor

Currently, when you run a workflow using ubuntu-latest and this action through nektos/act, it will hang during the save process due to sudo awaiting user input because /usr/sbin/purge isn't found (meaning you'll have to exec into the container and kill this sudo process to make it move on).

This change makes it only try to run purge if you're actually on a macOS runner.

Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the underlying bug was fixed, so it should be possible to remove that workaround altogether.

@heksesang
Copy link
Contributor Author

Updated the PR with rebuilt dist, as it seemed to fail on the check-dist workflow.

@Swatinem Swatinem merged commit 96a8d65 into Swatinem:master Sep 17, 2024
22 checks passed
@heksesang heksesang deleted the patch-1 branch September 19, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants