-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly cascade group permissions to all projects in the group #277
Conversation
You can access the deployment of this PR at https://renku-ci-ds-277.dev.renku.ch |
logging.info( | ||
f"The project namespace ID in Authzed {authzed_group_id} " | ||
f"does not match the expected group ID {correct_group_id}, correcting it..." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging doesn't work here btw (see #267).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I hope that it will when we fix the logging setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try swapping the alembic config level to info and see what happens. Hopefully alembic does not flood the console with lots of random messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logs look normal with the level set to INFO in alembic. So I will change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An easy way to have the logging work in the background job is to use logger = logging.getLogger("background_jobs")
and use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger = logging.getLogger("background_jobs")
logger.setLevel(logging.INFO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With logging level set to info in alembic it works, so I will keep it as is.
@@ -163,7 +163,7 @@ async def _get_namespaces( | |||
name=ns.name, | |||
slug=ns.latest_slug if ns.latest_slug else ns.slug, | |||
created_by=ns.created_by, | |||
creation_date=ns.creation_date, | |||
creation_date=None, # NOTE: we do not save creation date in the DB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep an issue to fix the API spec then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened one here: #283
Pull Request Test Coverage Report for Build 9635700701Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9636072700Details
💛 - Coveralls |
Tearing down the temporary RenkuLab deplyoment for this PR. |
Fixes #274
/deploy