Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new notebooks endpoints for new amalthea version #288

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olevski
Copy link
Member

@olevski olevski commented Jun 28, 2024

@andre-code let me know what you think.

@olevski olevski requested a review from a team as a code owner June 28, 2024 10:04
@olevski olevski marked this pull request as draft June 28, 2024 10:04
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olevski for including those changes. I checked what we currently use and found the following:

  • Does "running degraded" mean the session is stopping? What are the statuses for starting and stopping?

  • We use detailsand message for the start session progress bar and the session status popover, the rest isn't used in v2.:

{
    "details": [
        {"status": "waiting", "step": "Initialization"},
        {"status": "waiting", "step": "Downloading server image"},
        {"status": "waiting", "step": "Cloning and configuring the repository"},
        {"status": "waiting", "step": "Git credentials services"},
        {"status": "waiting", "step": "Authentication and proxying services"},
        {"status": "waiting", "step": "Auxiliary session services"},
        {"status": "waiting", "step": "Starting session"}
    ],
    "message": "Steps with non-ready statuses: initialization, downloading server image, cloning and configuring the repository, git credentials services, authentication and proxying services, auxiliary session services, starting session.",
    "readyNumContainers": 0,
    "state": "starting",
    "totalNumContainers": 7,
    "warnings": []
}
  • Can session_launcher_id be null for orphan sessions?

  • We show an alert icon when annotations.default_image_used is set and the session is running. Do you know if this is needed, and why?

  • Is created_at the same as started?

  • We use session.url to offer an "open in new tab" option, but it seems missing.

  • We show session.resources.request for resource changes when hibernating. The resource_class_id could no exist anymore and we lose that info

  • The schema for launching a session isn’t clear on sending more info than cloud storage IDs:

    • Can we send credentials?
    • Can we overwrite environment_variables?
    • What are the new values? the ones included in the jupyter free pitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants